The original commit on this branch (9ed74ca, then cherry-picked as
f776ce7) predated ADR-0019 / PR #91, which switched the portal-shell
build to `@angular/localize` and started emitting one self-contained
bundle per locale under `dist/apps/portal-shell/browser/<locale>/`.
The script looked for `index.html` directly under the dist root and
failed with ENOENT on every modern build.
Fix
- `scripts/check-gzip-budgets.mjs`:
- Auto-detects layout: if `dist/index.html` exists → flat mode
(unchanged behaviour). Otherwise enumerate immediate
subdirectories with their own `index.html` and run the check
per locale.
- Budget thresholds apply *per locale* — each bundle is what the
user's browser actually downloads. Aggregating across locales
would understate the worst case.
- Violations across locales are collected and reported together
so a single CI run surfaces every breach; the locale tag is
prefixed to each violation message for clarity.
- `docs/decisions/0017-...md` §Confirmation: spell out the per-locale
check + cite ADR-0019 so a future reader of either ADR sees the
connection.
Verified locally on the production build:
- 2 locale bundles detected (en, fr).
- Initial JS total: ~141 KB / 300 KB budget ✓ (each locale).
- CSS total: 4.62 KB / 150 KB budget ✓ (each locale).
- Largest lazy chunk: 1.55 KB / 100 KB per-chunk budget ✓.
Angular CLI's `budgets` only compare RAW sizes — there's no native
gzip-mode budget. ADR-0017 specifies thresholds in gzip-transfer
terms (initial bundle ≤ 300 KB gzip, any lazy chunk ≤ 100 KB gzip,
total stylesheet ≤ 150 KB gzip), so the project.json values today
are an approximate raw-size translation. The follow-up flagged in
ADR-0017's confirmation list — a CI check that asserts the actual
gzipped transfer size — lands here.
`scripts/check-gzip-budgets.mjs`:
- Parses Angular's emitted index.html to separate initial assets
(anything referenced via src=/href=) from lazy chunks (the rest).
- Gzips every JS / CSS file at level 9 — what most HTTP servers
serve for static assets — and reports a per-file + per-bucket
size table.
- Compares against the ADR-0017 budgets and exits non-zero on any
breach. Plain Node, no deps; ~120 lines.
Wired through:
- `pnpm ci:gzip-budgets` invokes the script with the default dist
path (`dist/apps/portal-shell/browser`).
- `ci:perf` chains build → gzip check → Lighthouse, so a
budget breach short-circuits before Lighthouse even runs (saves
several minutes on a failing PR).
ADR-0017 §Confirmation updated: the previous "future follow-up
will add a CI check" line is replaced by a description of how the
script works, with a link to it.
Verified locally on the production build:
- Initial JS total: 92.88 KB / 300 KB budget ✓
- Lazy chunks largest: 1.38 KB / 100 KB per-chunk budget ✓
- CSS total: 3.35 KB / 150 KB budget ✓
Julien Gautier