Commit Graph

2 Commits

Author SHA1 Message Date
Julien Gautier 22fd93a43a chore(brand): swap header logo to a real svg + ship favicons for portal-admin
CI / scan (pull_request) Successful in 3m13s
CI / commits (pull_request) Successful in 3m56s
CI / check (pull_request) Successful in 4m12s
CI / a11y (pull_request) Successful in 3m33s
CI / perf (pull_request) Successful in 9m23s
Two related brand-asset cleanups bundled per request:

portal-shell — header logo:
- Replace `apf-small.png` (a 7.6 KB raster wrapped through sharp from
  the original PNG-in-SVG file) with `apf-logo.svg`, an actual
  vector 1024×1024 export (2.1 KB). Sharper at any density, smaller
  payload, no rasterisation artefacts when the header zooms.
- `header.html` swaps the `<img src=…>` accordingly.
- The wide-format `apf-portal.svg` stays in place for future
  surfaces (login splash, etc.).

portal-admin — favicons + PWA manifest:
- Mirror portal-shell's PR #84 setup. Copy the six favicon image
  assets (favicon.ico, favicon.svg, favicon-96x96.png,
  apple-touch-icon.png, web-app-manifest-{192,512}.png) into
  `apps/portal-admin/public/favicons/`. Single visual identity
  across the two apps.
- Customise `site.webmanifest`: `name: "APF Portal Admin"`,
  `short_name: "Admin"`. PWA install banners and home-screen
  icons read the right app name when admin is installed
  standalone. Icon entries + theme-color + display stay identical
  to portal-shell.
- Wire `<link>` tags in `apps/portal-admin/src/index.html` mirroring
  portal-shell's, plus `<meta name="theme-color">`.
- Remove the now-obsolete top-level `apps/portal-admin/public/favicon.ico`
  (replaced by the entry under `favicons/`, referenced via
  `<link rel="shortcut icon">`).

Verified: `nx run-many -t lint test build --projects=portal-shell,
portal-admin` green; both `dist/.../browser/{en,fr}/favicons/` ship
the seven expected files; admin manifest contains "APF Portal Admin";
admin `index.html` has the right `<link>` block.
2026-05-12 11:56:08 +02:00
julien d962be838a feat(portal-admin): skeleton app per ADR-0020 (#100)
CI / check (push) Successful in 2m49s
CI / commits (push) Has been skipped
CI / scan (push) Successful in 2m32s
CI / a11y (push) Successful in 1m26s
CI / perf (push) Successful in 4m17s
## Summary

First step of the admin track per ADR-0020. Scaffold the second Angular SPA in the workspace alongside `portal-shell`, with the architectural decisions from the v1 ADRs already wired so subsequent feature PRs can drop straight into modules.

## What lands

- **App generated** via `nx g @nx/angular:application` (with the matching e2e project skeleton). Standalone, zoneless-ready, prefix `app`, scss component styles, css root stylesheet, no SSR.
- **Tags** `scope:portal-admin, type:app` — module-boundary lint now treats `portal-admin` distinctly from `portal-shell` and lets it depend only on `scope:portal-admin` + `scope:shared` libs.
- **Tailwind v4 + brand tokens**: `.postcssrc.json`, `@import 'tailwindcss'`, class-based dark variant, and `@import '../../../libs/shared/tokens/src/brand-tokens.css'` — identical visual baseline to portal-shell.
- **i18n config mirrors portal-shell** (per ADR-0019): sourceLocale `en`, target `fr`, baseHref `/{locale}/` per locale, `@angular/localize/init` polyfill, `localize: ["en", "fr"]` on production, `i18nMissingTranslation: "error"` so CI blocks any PR that adds a marker without translating it. Seed [`messages.fr.xlf`](apps/portal-admin/src/locale/messages.fr.xlf) carries the four marked strings used today.
- **Budgets** relaxed to **500 KB gzip initial** per ADR-0020 §"Performance budgets" (vs 300 KB for portal-shell).
- **Skeleton home page** at `/` — `<h1>` + intro paragraph + "Skeleton — coming soon" chip in the brand-accent palette. All marked for i18n.
- **Skip-link landmark** (WCAG 2.4.1) with the same component-scoped scss as portal-shell.
- **Wildcard catch-all route** → bounces unknown paths to home (same defensive pattern as PR #96 on portal-shell).
- **Dev server on port 4300** (vs 4200 for portal-shell) — both can run in parallel.
- **`serve-static` target without `spa: true`** — locale-prefixed routing in production is handled by the reverse proxy (per ADR-0019), same as portal-shell since PR #92.

## CLAUDE.md

Picked up the second app in the **Naming** entry and the **Commands** snippet (`<app>` is now one of `portal-shell`, `portal-admin`, `portal-bff`).

## Verification

- `pnpm exec nx run-many -t lint test build --projects=portal-shell,portal-admin,shared-ui,shared-state,shared-tokens` — green.
- `portal-admin` test: 1 spec (skip-link + main landmark present).
- Production build of `portal-admin`: **62 KB gzip initial per locale** (vs 500 KB budget — plenty of headroom for the upcoming modules).
- Both `dist/apps/portal-admin/browser/{en,fr}/` emit with the right `<html lang>` and `<base href>`. FR bundle contains `"Administration"` / `"Squelette"` / `"bientôt disponible"` — translations applied.
- portal-shell production build unchanged.

## Out of scope (each its own follow-up PR)

- Admin app shell (header / sidebar / footer with "Admin" badge — likely sharing graduated primitives plus admin-specific bits).
- OpenTelemetry tracing setup (`service.name=portal-admin` per ADR-0012).
- `environment.ts` wiring (per ADR-0018) for admin-specific endpoints.
- BFF `AdminModule` + `AdminRoleGuard` + smoke `/api/admin/me` (per ADR-0020 §"Auth").
- First functional module — CMS / menu / users / audit viewer.

## Test plan

- [x] Lint + test + build green across the workspace.
- [x] Per-locale production build emits both folders with correct metadata.
- [ ] Manual: `pnpm exec nx serve portal-admin` boots on `:4300`, smoke page renders.
- [ ] Manual: prod build + `pnpm exec nx run portal-admin:serve-static` → `http://localhost:4300/en/` and `/fr/` show the placeholder with the matching language.

---------

Co-authored-by: Julien Gautier <julien.gautier@apf.asso.fr>
Reviewed-on: #100
2026-05-12 01:49:19 +02:00