julien/apf_portal
1
0
Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(portal-bff): use bracket notation for process.env access

Browse Source 
The strict-TS option noPropertyAccessFromIndexSignature: true (set in
tsconfig.base.json per ADR-0004) forbids dot-notation access on index
signatures. process.env is typed as { [key: string]: string | undefined }
so process.env.PORT must be written process.env['PORT']. The Nx
generator wrote the dot form by default; fix to comply with the
project's strict-TS bar.

Touched: portal-bff main.ts and the three portal-bff-e2e support files
(global-setup, global-teardown, test-setup).
This commit is contained in:
Julien Gautier
2026-04-30 16:34:17 +02:00
parent bea5e1954f
commit 0774014599
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/portal-bff-e2e/src/support/global-setup.ts
+2 -2
View File
@@ -7,8 +7,8 @@ module.exports = async function () {
// Start services that that the app needs to run (e.g. database, docker-compose, etc.). // Start services that that the app needs to run (e.g. database, docker-compose, etc.).
console.log('\nSetting up...\n'); console.log('\nSetting up...\n');
const host = process.env.HOST ?? 'localhost'; const host = process.env['HOST'] ?? 'localhost';
const port = process.env.PORT ? Number(process.env.PORT) : 3000; const port = process.env['PORT'] ? Number(process.env['PORT']) : 3000;
await waitForPortOpen(port, { host }); await waitForPortOpen(port, { host });
// Hint: Use `globalThis` to pass variables to global teardown. // Hint: Use `globalThis` to pass variables to global teardown.
apps/portal-bff-e2e/src/support/global-teardown.ts
+1 -1
View File
@@ -4,7 +4,7 @@ import { killPort } from '@nx/node/utils';
module.exports = async function () { module.exports = async function () {
// Put clean up logic here (e.g. stopping services, docker-compose, etc.). // Put clean up logic here (e.g. stopping services, docker-compose, etc.).
// Hint: `globalThis` is shared between setup and teardown. // Hint: `globalThis` is shared between setup and teardown.
const port = process.env.PORT ? Number(process.env.PORT) : 3000; const port = process.env['PORT'] ? Number(process.env['PORT']) : 3000;
await killPort(port); await killPort(port);
console.log(globalThis.__TEARDOWN_MESSAGE__); console.log(globalThis.__TEARDOWN_MESSAGE__);
}; };
apps/portal-bff-e2e/src/support/test-setup.ts
+2 -2
View File
@@ -3,7 +3,7 @@ import axios from 'axios';
module.exports = async function () { module.exports = async function () {
// Configure axios for tests to use. // Configure axios for tests to use.
const host = process.env.HOST ?? 'localhost'; const host = process.env['HOST'] ?? 'localhost';
const port = process.env.PORT ?? '3000'; const port = process.env['PORT'] ?? '3000';
axios.defaults.baseURL = `http://${host}:${port}`; axios.defaults.baseURL = `http://${host}:${port}`;
}; };
apps/portal-bff/src/main.ts
+1 -1
View File
@@ -18,7 +18,7 @@ async function bootstrap() {
const globalPrefix = 'api'; const globalPrefix = 'api';
app.setGlobalPrefix(globalPrefix); app.setGlobalPrefix(globalPrefix);
const port = process.env.PORT || 3000; const port = process.env['PORT'] || 3000;
await app.listen(port); await app.listen(port);
Logger.log(`Application is running on: http://localhost:${port}/${globalPrefix}`); Logger.log(`Application is running on: http://localhost:${port}/${globalPrefix}`);
} }